Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Filter user activities pagination #152702

Merged

Conversation

js-jankisalvi
Copy link
Contributor

@js-jankisalvi js-jankisalvi commented Mar 6, 2023

Summary

Implements #130227

pagination.mov

Checklist

Delete any items that are not applicable to this PR.

Flaky Test Runner

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2059

For maintainers

@js-jankisalvi js-jankisalvi self-assigned this Mar 6, 2023
@js-jankisalvi js-jankisalvi added the Feature:Cases Cases feature label Mar 6, 2023
@js-jankisalvi js-jankisalvi changed the title Filter activities pagination [Cases]: Filter activities pagination Mar 6, 2023
@js-jankisalvi js-jankisalvi changed the title [Cases]: Filter activities pagination [Cases] Filter activities pagination Mar 6, 2023
@js-jankisalvi js-jankisalvi added release_note:enhancement Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0 labels Mar 9, 2023
@js-jankisalvi js-jankisalvi changed the title [Cases] Filter activities pagination [Cases] Filter user activities pagination Mar 9, 2023
@js-jankisalvi js-jankisalvi requested a review from a team March 9, 2023 15:02
@js-jankisalvi js-jankisalvi marked this pull request as ready for review March 9, 2023 15:02
@js-jankisalvi js-jankisalvi requested a review from a team as a code owner March 9, 2023 15:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@cnasikas
Copy link
Member

cnasikas commented Apr 3, 2023

I found out that when pressing the "Show more button" the loading spinner does not show on the button.

Because we show user actions and button only after loading is finished 😄

You can use the isFetchingNextPage (provided by react query) which is true only when we fetch a new page (the user clicks the show more button).

@adcoelho
Copy link
Contributor

adcoelho commented Apr 3, 2023

If I have some items at the end of the list and click Show more until all are displayed, there will be no margin between the activity items. Maybe you could add some there?

closed Screenshot 2023-04-03 at 12 39 35
open (missing margin) Screenshot 2023-04-03 at 12 39 57

@adcoelho
Copy link
Contributor

adcoelho commented Apr 3, 2023

The copy reference link action doesn't work if the item we are trying to link to is inside a page 😬

At the beginning of the video, I link to an item from the first page, which works fine. It also works if the linked item belongs to the last page.

Screen.Recording.2023-04-03.at.13.00.29.mov

@cnasikas
Copy link
Member

cnasikas commented Apr 3, 2023

The copy reference link action doesn't work if the item we are trying to link to is inside a page 😬

Yes, we discussed this and decided to leave it on another PR. @js-jankisalvi Could you please open an issue so we can address it?

Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀! I am so happy to see this feature live.

@js-jankisalvi
Copy link
Contributor Author

Yes, we discussed this and decided to leave it on another PR. @js-jankisalvi Could you please open an issue so we can address it?

Created issue

@js-jankisalvi
Copy link
Contributor Author

If I have some items at the end of the list and click Show more until all are displayed, there will be no margin between the activity items. Maybe you could add some there?

Fixed in 024ff50

Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @js-jankisalvi !

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 565 572 +7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 364.3KB 368.8KB +4.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 133.3KB 133.3KB -64.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
cases 56 57 +1
securitySolution 432 435 +3
total +4

Total ESLint disabled count

id before after diff
cases 74 75 +1
securitySolution 512 515 +3
total +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @js-jankisalvi

@js-jankisalvi js-jankisalvi merged commit 6eb2c5e into elastic:main Apr 4, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 4, 2023
@cnasikas cnasikas added release_note:feature Makes this part of the condensed release notes and removed release_note:enhancement labels May 3, 2023
@js-jankisalvi js-jankisalvi deleted the filter-activities-pagination branch October 6, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:feature Makes this part of the condensed release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants